deprecate is_torch_bf16_available #17738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas00
commented
Jun 16, 2022
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Jun 17, 2022
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
Great, thanks a lot for splitting things up like this!
Contributor
Author
|
does it look good now, Sylvain? |
Collaborator
|
Yes, all good :-) Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #17734 where @pacman100 discovered that the IPEX PR made
is_torch_bf16_availableambiguous, as it went from gpu-only checks to cpu or gpu which is undefined behavior.So this PR deprecates this function in favor of the very specific
is_torch_bf16_gpu_availableandis_torch_bf16_cpu_availablethat were added in #17734@sgugger