Closed
Conversation
stas00
reviewed
May 26, 2022
stas00
reviewed
May 26, 2022
Contributor
stas00
left a comment
There was a problem hiding this comment.
Added a few small suggestions - please validate that I didn't break anything - as I haven't tested the proposed changes.
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
stas00
reviewed
May 27, 2022
stas00
reviewed
May 28, 2022
src/transformers/models/bloom/convert_bloom_original_checkpoint_to_pytorch.py
Outdated
Show resolved
Hide resolved
stas00
reviewed
May 28, 2022
src/transformers/models/bloom/convert_bloom_original_checkpoint_to_pytorch.py
Outdated
Show resolved
Hide resolved
stas00
reviewed
May 28, 2022
src/transformers/models/bloom/convert_bloom_original_checkpoint_to_pytorch.py
Outdated
Show resolved
Hide resolved
stas00
reviewed
May 28, 2022
src/transformers/models/bloom/convert_bloom_original_checkpoint_to_pytorch.py
Outdated
Show resolved
Hide resolved
Muennighoff
reviewed
May 28, 2022
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
Co-authored-by: Niklas Muennighoff <n.muennighoff@gmail.com>
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
Apply suggestions from Stas comments Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
5 tasks
Contributor
patrickvonplaten
left a comment
There was a problem hiding this comment.
The git commit history seems to be messed up - should we maybe open a new PR here?
Contributor
Author
|
Yeah let me close it and create a new PR! |
Contributor
Author
|
Moved the PR at #17474 |
Contributor
It appears to be due to a broken merge commit here: 06d98db Didn't really need a new PR, but rolling back the bad commit. But oh well it's done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Integrating BigScience converted models into HuggingFace library!
Original PR: thomwolf#2 that I directly moved here
cc @thomasw21 @thomwolf @sgugger @stas00
EDIT: PR moved at #17474