Skip to content

MLflowCallback set experiment name#17067

Closed
orieg wants to merge 1 commit intohuggingface:mainfrom
orieg:mlflowcallback-set-experiment-name
Closed

MLflowCallback set experiment name#17067
orieg wants to merge 1 commit intohuggingface:mainfrom
orieg:mlflowcallback-set-experiment-name

Conversation

@orieg
Copy link
Contributor

@orieg orieg commented May 3, 2022 •
edited
Loading

What does this PR do?

This PR includes the following:

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sgugger

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 3, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@orieg orieg mentioned this pull request May 3, 2022
Closed
4 tasks
sgugger
sgugger approved these changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing all of these!

@sgugger
Copy link
Collaborator

sgugger commented May 4, 2022

Oh actually, multiple checks in our CI are not running for some reason. Can you try sending empty commits to see if it triggers it?

@orieg
Copy link
Contributor Author

orieg commented May 4, 2022

@sgugger I tried an empty commit, a comment change on the py file, and a rebase. They all trigger only two checks. They seem to pass tho.

@sgugger
Copy link
Collaborator

sgugger commented May 4, 2022

Yes, but for some reason, the whole battery of tests run by cicleCI is not launching (check any other PR to see there are actually 18 to 20 checks). I have no idea why they don't, and can't merge without being sure nothing is broken by the PR.

@orieg orieg mentioned this pull request May 4, 2022
Merged
5 tasks
@orieg
Copy link
Contributor Author

orieg commented May 4, 2022

@sgugger no clue what's going on. I even tried a new PR in #17091 which also trigger only two CI jobs.

@sgugger
Copy link
Collaborator

sgugger commented May 4, 2022

I have no idea what the problem is. Wrote to circleCI support to try to get some help.

@orieg
Copy link
Contributor Author

orieg commented May 5, 2022

Closing this PR in favor of #17091, which is running all the CI tests.

@orieg orieg closed this May 5, 2022
@orieg orieg deleted the mlflowcallback-set-experiment-name branch May 5, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sgugger sgugger sgugger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect check for MLFlow active run in MLflowCallback Set Experiment Name in MLflowCallback

3 participants

@orieg @HuggingFaceDocBuilderDev @sgugger