don't load state_dict twice when using low_cpu_mem_usage in from_pretrained#16602
Merged
patil-suraj merged 1 commit intohuggingface:mainfrom Apr 6, 2022
Merged
don't load state_dict twice when using low_cpu_mem_usage in from_pretrained#16602patil-suraj merged 1 commit intohuggingface:mainfrom
patil-suraj merged 1 commit intohuggingface:mainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Apr 5, 2022
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
To complete the description, it's fine to remove it there because when is_sharded=False, the state_dict is loaded at line 1797.
LysandreJik
approved these changes
Apr 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In
from_pretrainedthestate_dictis loaded twice whenlow_cpu_mem_usageisTrue, which is not required since thestate_dictis already loaded before as we can here.transformers/src/transformers/modeling_utils.py
Lines 1795 to 1797 in 21decb7
So, it's fine to remove it there because when is_sharded=False, the state_dict is loaded at line 1797