Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
| depths (`List[int]`, *optional*, defaults to `[3, 4, 6, 3]`): | ||
| Depth (number of layers) for each stage. | ||
| layer_type (`str`, *optional*, defaults to `"bottleneck"`): | ||
| The layer to use, it can be either `"x" or `"y"` (like `x` but with squeeze and excitation). |
There was a problem hiding this comment.
updated the doc
There was a problem hiding this comment.
The default needs to be update (it's "y" not "bottleneck") and what "x" and "y" mean should be detailed here in the docstring for people who did not read the paper.
There was a problem hiding this comment.
Updated, let me know if it is better
sgugger
left a comment
There was a problem hiding this comment.
Thanks for working on this new model. I left a few comments, but it's in good shape to be merged.
| depths (`List[int]`, *optional*, defaults to `[3, 4, 6, 3]`): | ||
| Depth (number of layers) for each stage. | ||
| layer_type (`str`, *optional*, defaults to `"bottleneck"`): | ||
| The layer to use, it can be either `"x" or `"y"` (like `x` but with squeeze and excitation). |
There was a problem hiding this comment.
The default needs to be update (it's "y" not "bottleneck") and what "x" and "y" mean should be detailed here in the docstring for people who did not read the paper.
f135aee to
4025d7d
Compare
94ce99b to
4ff7b1a
Compare
|
Updated the codebase to use |
303c1a6 to
45319dd
Compare
|
Conversion script for the 10B regnet model added + needed changes inside |
Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com>
123096e to
fa5506e
Compare
|
Thanks to all reviewers, I've rebased and updated the code accordingly |
What does this PR do?
This WIP PR adds RegNet.
Currently, the model can be used as follows