Skip to content

Set run_name in MLflowCallback#14894

Merged
sgugger merged 2 commits intohuggingface:masterfrom
yangdong02:patch-1
Dec 23, 2021
Merged

Set run_name in MLflowCallback#14894
sgugger merged 2 commits intohuggingface:masterfrom
yangdong02:patch-1

Conversation

@yangdong02
Copy link
Contributor

What does this PR do?

Currently, when using mlflow integration to track experiments, runs are being logged as nameless. E.g. see below (image from #8519). This PR is a simple one-line fix of passing args.run_name (which is currently used for wandb) to mlflow.start_run. It also updates the doc of args.run_name.

image

Fixes #8519, #12841

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed.

@sgugger

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this!

@sgugger sgugger merged commit 2d30443 into huggingface:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MLflowCallback to log run_name argument

2 participants