Fix preprocess_function in run_summarization_flax.py#14769
Merged
patil-suraj merged 1 commit intohuggingface:masterfrom Dec 15, 2021
Merged
Fix preprocess_function in run_summarization_flax.py#14769patil-suraj merged 1 commit intohuggingface:masterfrom
patil-suraj merged 1 commit intohuggingface:masterfrom
Conversation
Contributor
|
@patil-suraj - could you take this one? :-) |
patil-suraj
approved these changes
Dec 15, 2021
Contributor
patil-suraj
left a comment
There was a problem hiding this comment.
Great catch! Thanks a lot for fixing this @ydshieh !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
run_summarization_flax.pyhastransformers/examples/flax/summarization/run_summarization_flax.py
Lines 535 to 537 in e7ed7ff
Using
jnp.arrayhere will causepreprocess_functionto hang forever when it is used bydatasets.Dataset.map()withnum_proc > 1, when this script is running on a TPU VM.I think it is related to #12719 and #12720
Who can review?
@patil-suraj @patrickvonplaten