[Example] Fix a NaN bug in the flax mlm example#10796
Closed
merrymercy wants to merge 1 commit intohuggingface:masterfrom
merrymercy:pr-fix-flax
Closed
[Example] Fix a NaN bug in the flax mlm example#10796merrymercy wants to merge 1 commit intohuggingface:masterfrom merrymercy:pr-fix-flax
merrymercy wants to merge 1 commit intohuggingface:masterfrom
merrymercy:pr-fix-flax
Conversation
This was referenced Apr 13, 2021
Contributor
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Contributor
Author
Contributor
|
Hey @merrymercy - super sorry, I saw the PR too late and it was actually already fixed. |
Contributor
Author
|
Thanks for your effort on Jax integration! @patrickvonplaten |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a NaN bug in the flax masked language model example. This is a bug introduced in #9133
The min should be max. Otherwise, we will get a NaN.
Who can review?
@TevenLeScao @mfuntowicz