Revert "Changing Decoder trait to be more composable. (#938)"#971
Merged
Revert "Changing Decoder trait to be more composable. (#938)"#971
Decoder trait to be more composable. (#938)"#971Conversation
This reverts commit cdabef1.
SaulLu
approved these changes
Apr 1, 2022
Contributor
SaulLu
left a comment
There was a problem hiding this comment.
Thanks again for all the effort! I'm sure that the PR remains a useful first version to design a second solution to make the decoders composable! 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit cdabef1.
Despite some efforts to try and check that this breaking change was going to be seamless for
transformers, it wasn't.Fortunately this was caught relatively early after publishing.
The decision was made to just unpublish
0.12.0in order to not ship any breaking changes with it.More information in
transformersitself huggingface/transformers#16537 (comment)Reflecting this on master is what this PR is for, we can then make a different attempt of modifications for : #938 without any breaking changes.