Remove runtime stderr warning from Python bindings#1898
Merged
ArthurZucker merged 3 commits intomainfrom Nov 28, 2025
Merged
Conversation
Remove the eprintln! calls that printed a runtime warning to stderr when the process was forked after parallelism had been used. The set_parallelism(false) behavior is preserved to avoid deadlocks. File changed: bindings/python/src/lib.rs Commit OID referenced: a05b60c Co-authored-by: ArthurZucker <48595927+ArthurZucker@users.noreply.github.com>
Collaborator
|
Lol cc @sgugger as you requested it :) |
The comment now correctly states that the callback disables parallelism instead of warning the user. Co-authored-by: ArthurZucker <48595927+ArthurZucker@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove stderr warning from Python bindings
Remove runtime stderr warning from Python bindings
Nov 28, 2025
ArthurZucker
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
eprintln!calls inchild_after_fork()that print warnings to stderr when forking after parallelism has been used. The deadlock prevention behavior (set_parallelism(false)) is preserved.Changes:
eprintln!statements frombindings/python/src/lib.rs(ref:a05b60c55f29814631b0b0c92ba51b178cc126f6#L47)Before:
After:
Note: If logging is desired in the future, the existing
env_loggerintegration (TOKENIZERS_LOG) could be used instead of direct stderr writes.Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.