Implement from_bytes and read_bytes Methods in WordPiece Tokenizer for WebAssembly Compatibility#1758
Merged
ArthurZucker merged 3 commits intohuggingface:mainfrom Jul 29, 2025
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| vocab.insert(line.trim_end().to_owned(), index as u32); | ||
| } | ||
|
|
||
| Ok(vocab) |
Collaborator
There was a problem hiding this comment.
this currently breaks on main! We switch to using AHashmap, I suspect the branch was not up to date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This Pull Request introduces the implementation of
from_bytesandread_bytesmethods within the WordPiece tokenizer. These methods were added to improve integration with WebAssembly (Wasm). As model downloading is managed on the JavaScript side in a Wasm target environment, methods compatible withu8types facilitates the transfer of aUint8Arrayfrom JavaScript to Rust.