remove enforcement of non special when adding tokens#1521
Merged
ArthurZucker merged 10 commits intomainfrom Apr 30, 2024
Merged
remove enforcement of non special when adding tokens#1521ArthurZucker merged 10 commits intomainfrom
ArthurZucker merged 10 commits intomainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Narsil
approved these changes
Apr 30, 2024
Contributor
Narsil
left a comment
There was a problem hiding this comment.
LGTM.
Not sure if we should mark it as breaking chnage (it is technically, although we're more respectful of user intent which could categorize as bugfix)
Collaborator
Author
|
we'll do a "breaking" release soon anyways! More a bug fix IMO! |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issue that prevented us from adding special and non special tokens using a single call to
add_tokens.Very important because calling this multiple times adds a huge slowdown (regex re-compilation).
before it would output
'<me-and-you>'. and the token was always special when added.This will allow us to do the following cleanup: https://github.com/huggingface/transformers/blob/main/src/transformers/tokenization_utils_fast.py#L169-L192
this issue comes from c02d4e2 which was introduced in v0.8