Make tools and additionalContext optional#169
Merged
pcuenca merged 1 commit intohuggingface:mainfrom Jan 31, 2025
Merged
Conversation
1bc7355 to
8081d67
Compare
Member
|
I suppose we could also handle the empty array, but it's ok. |
Contributor
Author
|
Thank you! I'll be able to submit my tool use example in mlx-swift-examples once there's a new release tag for swift-transformers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm finishing up the tools example in mlx-swift-examples, and it occurred to me that
toolsandadditionalContextshould probably be optional. Otherwise you might want to pass in an empty array, and that could affect how the template renders the prompt if it only checks iftoolsis defined, and not iftoolsis empty. What do you think, @pcuenca?