Fix InformationRetrievalEvaluator prediction export when output_path does not exist#3659
Merged
tomaarsen merged 3 commits intoFeb 17, 2026
Merged
Conversation
Member
|
Hello! This is great, thanks for spotting and resolving it. I wanted to quickly reproduce it with the snippet in the docs, but then I noticed it was a bit dated and the dataset can't be loaded anymore. So, I replaced the docs snippet slightly. I think this is all ready to go! I also pulled
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug in
InformationRetrievalEvaluatorwhere prediction file writing could fail whenwrite_predictions=Trueand the providedoutput_pathdid not already exist.Root Cause
compute_metrices()writes prediction JSONL files, but directory creation foroutput_pathoccurs aftercompute_metrices()is called within__call__().Changes
compute_metrices()before file is writtenMinimal Example