fix(optim): replace bare except with Exception in Lion optimizer#2666
Merged
rwightman merged 1 commit intohuggingface:mainfrom Feb 11, 2026
Merged
Conversation
Replaces a bare `except:` clause with `except Exception:` in `timm/optim/lion.py`. The previous bare except caught `BaseException`, which includes `SystemExit` and `KeyboardInterrupt`. This ensures that system control signals (like Ctrl+C) propagate correctly while still handling runtime errors during the capability check.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces a bare
except:clause withexcept Exception:intimm/optim/lion.py.The previous implementation caught
BaseException, which includesSystemExitandKeyboardInterrupt. This prevented the user from interrupting the process (Ctrl+C) during theforeachcapability check.Verification
Verified via code inspection. This ensures standard runtime errors (like
AttributeErrororRuntimeErrorfromtorch.ops) are caught, while allowing system control signals to propagate correctly.