Add AdaMSS tuner with Adaptive Subspace Allocation (ASA) support#2967
Closed
LonglongaaaGo wants to merge 18 commits intohuggingface:mainfrom
Closed
Add AdaMSS tuner with Adaptive Subspace Allocation (ASA) support#2967LonglongaaaGo wants to merge 18 commits intohuggingface:mainfrom
LonglongaaaGo wants to merge 18 commits intohuggingface:mainfrom
Conversation
Member
|
Thank you for your PR @LonglongaaaGo. We're currently off for the holidays, so a proper review will have to wait for next year. I did skim the code though and just wanted to add a few comments:
|
Member
|
@LonglongaaaGo Please ping me when the PR is ready for review. |
Author
Hey @BenjaminBossan, Sure! I will let you know once it is ready. Thank you!!! |
Author
|
This PR was replaced by this PR: #2987 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paper title: AdaMSS: Adaptive Multi-Subspace Approach for Parameter-Efficient Fine-Tuning
Paper: https://neurips.cc/virtual/2025/loc/san-diego/poster/119606
Github page: https://github.com/jzheng20/AdaMSS/tree/main
Summary
This PR adds AdaMSS (Adaptive Multi-Subspace Selection) as a new PEFT tuner with optional ASA (Adaptive Subspace Allocation) for dynamic subspace selection during training.
Implementation
New Tuner: AdaMSS
ASA Features (Optional)
ASACallbackfor Transformers Trainerupdate_and_allocate()method following AdaLora conventionFiles Modified
Added:
src/peft/tuners/adamss/config.pysrc/peft/tuners/adamss/layer.pysrc/peft/tuners/adamss/model.pysrc/peft/tuners/adamss/asa_callback.pysrc/peft/tuners/adamss/__init__.pyModified:
src/peft/__init__.py- Export AdaMSSConfig, AdaMSSModel, ASACallbacksrc/peft/tuners/__init__.py- Export AdaMSS tunersrc/peft/utils/peft_types.py- Add ADAMSS PeftTypesrc/peft/tuners/adamss/__init__.py- Register AdaMSS withregister_peft_method()Usage Examples
Basic Usage (No ASA)
With ASA - Callback Pattern
With ASA - Standard Pattern
Algorithm Details
AdaMSS Decomposition
ASA Schedule
Design Notes
BaseTunerandBaseTunerLayerpatterns consistent with other PEFT tunersupdate_and_allocate()method follows AdaLora convention for dynamic allocation