Ignore documents with "output" scheme#59
Merged
McPatate merged 1 commit intohuggingface:mainfrom Jan 28, 2024
Merged
Conversation
4ede048 to
af1e3f4
Compare
af1e3f4 to
5d2742a
Compare
McPatate
approved these changes
Jan 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the VSCode extension there is a "*"
documentFilterset (https://github.com/huggingface/llm-vscode/blob/master/src/extension.ts#L63), which sends document did_change events for ALL updates it has e.g. when files on the filesystem changed (which will have schemefile:or unsaved onesuntitled. However this also includes the VSCode "Output" tab.As it happens this output is coming from llm-ls itself. Whenever we log a message to the client, e.g. in
the output changes and we trigger the event. This is problematic in the case of the mentioned log, since this basically triggers an infinite loop of logs and changed events.
There are two ways to fix this:
documentFilterin the VSCode client to ignoreoutputscheme, I think this could look like the following:The problem is there is no "negate" operator, which means we have to exhaustively list everything we want to get, and I couldn't find an enumeration.
2. just ignoring the
outputscheme. This seems like low risk, since no valuable input for code completion can get out of it anywayFixes huggingface/llm-vscode#120