Skip to content

Ignore documents with "output" scheme#59

Merged
McPatate merged 1 commit intohuggingface:mainfrom
HennerM:ignore-output-changes
Jan 28, 2024
Merged

Ignore documents with "output" scheme#59
McPatate merged 1 commit intohuggingface:mainfrom
HennerM:ignore-output-changes

Conversation

@HennerM
Copy link
Copy Markdown
Contributor

@HennerM HennerM commented Jan 20, 2024

In the VSCode extension there is a "*" documentFilter set (https://github.com/huggingface/llm-vscode/blob/master/src/extension.ts#L63), which sends document did_change events for ALL updates it has e.g. when files on the filesystem changed (which will have scheme file: or unsaved ones untitled. However this also includes the VSCode "Output" tab.

As it happens this output is coming from llm-ls itself. Whenever we log a message to the client, e.g. in

self.client
    .log_message(MessageType::INFO, format!("{uri} changed"))
    .await;

the output changes and we trigger the event. This is problematic in the case of the mentioned log, since this basically triggers an infinite loop of logs and changed events.

There are two ways to fix this:

  1. setting the documentFilter in the VSCode client to ignore output scheme, I think this could look like the following:
documentSelector: [{ scheme: 'file'}, {scheme: 'untitled'}],

The problem is there is no "negate" operator, which means we have to exhaustively list everything we want to get, and I couldn't find an enumeration.
2. just ignoring the output scheme. This seems like low risk, since no valuable input for code completion can get out of it anyway

Fixes huggingface/llm-vscode#120

@HennerM HennerM force-pushed the ignore-output-changes branch from af1e3f4 to 5d2742a Compare January 23, 2024 22:53
@McPatate McPatate merged commit c2fbac2 into huggingface:main Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Continuous file change events

2 participants