Skip to content

feat!: make API camelCase#46

Merged
McPatate merged 2 commits intomainfrom
feat!/getComletions_camelCase
Nov 9, 2023
Merged

feat!: make API camelCase#46
McPatate merged 2 commits intomainfrom
feat!/getComletions_camelCase

Conversation

@McPatate
Copy link
Copy Markdown
Member

@McPatate McPatate commented Nov 9, 2023

API had inconsistencies in case

@McPatate McPatate force-pushed the feat!/getComletions_camelCase branch from 9a120cf to d8e313d Compare November 9, 2023 10:46
@McPatate McPatate merged commit 59185ab into main Nov 9, 2023
@McPatate McPatate deleted the feat!/getComletions_camelCase branch November 9, 2023 11:00
@HennerM
Copy link
Copy Markdown
Contributor

HennerM commented Dec 27, 2023

Hi, I am currently looking into the codebase because I really like the idea of using local or open LLMs to get code completion.

I noticed this change and don't know why this was done, in the VSCode extension, snake_case is used throughout (https://github.com/huggingface/llm-vscode/blob/master/src/extension.ts#L151-L155) and even in the nvim and IntelliJ implementations. Is there any documentation as to what is right?

@McPatate
Copy link
Copy Markdown
Member Author

McPatate commented Jan 2, 2024

Hi @HennerM, I haven't released a new version yet, I'll do so when I update all the extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants