[fix] Transient locaion error due to CDN#4339
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
This PR has been shipped as part of the v1.19.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should fix this transient error
CDN is used only X% of the time, hence the transient error and the need for a double check
Note
Low Risk
Test-only change with no production code or security impact.
Overview
Fixes flaky CI in
test_get_hf_file_metadata_from_a_lfs_fileby loosening the redirect URL check when fetching LFS metadata forgpt2/tf_model.h5.The test no longer requires
metadata.locationto always includexethub.hf.co; it now passes if the final URL containsxethub.hf.coorcdn.hf.co, matching intermittent Hub routing to the CDN. The LFS size assertion is unchanged.Reviewed by Cursor Bugbot for commit 79a5f43. Bugbot is set up for automated code reviews on this repo. Configure here.