Fix ignored-pattern warning grammar in download CLI#4337
Merged
Wauplin merged 2 commits intoJun 11, 2026
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
approved these changes
Jun 11, 2026
Contributor
|
This PR has been shipped as part of the v1.19.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hf downloadfrom 'have being' to 'have been'--includeand--excludeWhy
These warnings are user-facing CLI output. Fixing the grammar makes the message clearer, and the stronger assertion helps prevent the typo from coming back.
Validation
download()with ignored patterns and checks the exact warning messagespython -m py_compile src/huggingface_hub/cli/download.py tests/test_cli.pyNote
Low Risk
Copy-only CLI warning text plus a stricter unit test; no download behavior changes.
Overview
Fixes user-facing
hf downloadwarnings when positional filenames override--include/--exclude: the message now says "have been" instead of "have being".The regression test
test_download_with_ignored_patternsno longer only checks that some warning contains "Ignoring"; it asserts the exact text and order of both warnings.Reviewed by Cursor Bugbot for commit ce0aab8. Bugbot is set up for automated code reviews on this repo. Configure here.