[Auth] Take google colab token from env first#4323
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
This PR has been shipped as part of the v1.19.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally from @xenova on slack (internal):
This PR fixes this. If a user runs
loginin a Colab (saves the token in a local file) or sets an env variable, it should take precedence over the Colab's vault.Note
Medium Risk
Changes authentication precedence in Google Colab, which can alter which HF account is used for hub requests when multiple token sources exist.
Overview
Reorders HF token resolution in Colab so explicit user credentials win over the notebook secrets vault.
get_token()now checksHF_TOKEN/HUGGING_FACE_HUB_TOKEN, then the on-disk token file (e.g. afterlogin()), and only then Google Colab’sHF_TOKENsecret. Previously Colab’s vault was consulted first, which could override a token the user had just saved vialogin()or set in the environment.Reviewed by Cursor Bugbot for commit e3e2a9b. Bugbot is set up for automated code reviews on this repo. Configure here.