fix(release.yml): restore env: block on 'Detect version' step#4267
Merged
Conversation
PR #4264 removed the env: block on the 'Detect version' step and inlined `RELEASE_TYPE="${{ inputs.release_type }}"` directly into the run script. That patch was produced by an autofix bot in response to a false-positive command_injection finding; the env-block pattern that was already in place is the project's recommended mitigation, so the autofix was a regression. Restoring the env: block restores the consistent convention for this repo (all ${{ ... }} expressions used inside a run: script are first mapped to shell variables via env:). Tracking: huggingface/tracking-issues#780 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
approved these changes
May 26, 2026
Contributor
|
This PR has been shipped as part of the v1.17.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
env:block on theDetect versionstep in.github/workflows/release.ymlthat was removed by chore: update release.yml #4264.