[CI] Add import check with base dependencies only#4250
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
This PR has been shipped as part of the v1.17.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(related slack thread)
Summary
check-importsjob to the CI that installshuggingface_hubwith only base dependencies (no extras) and runsfrom huggingface_hub import *.install_requires, which would result in anImportErrorfor users installing the package without dev extras.Motivated by #4248 where a transitive dependency (
urllib3) was imported at the top level, causing anImportErrorfor users after release. The existing CI didn't catch it because test dependencies pull in the missing library.🤖 Generated with Claude Code
Note
Low Risk
Low risk since it only changes CI configuration; potential impact is limited to longer or occasionally flakier CI runs due to the new environment setup step.
Overview
Adds a new
check-importsGitHub Actions job that creates a fresh venv, installs the project with base dependencies only (uv pip install .), and runsfrom huggingface_hub import *to catch missinginstall_requiresdependencies in the public API surface before release.Reviewed by Cursor Bugbot for commit dd7c6bc. Bugbot is set up for automated code reviews on this repo. Configure here.