Fix catch-all empty string in CI pytest --only-rerun#4239
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4239 +/- ##
==========================================
+ Coverage 75.00% 77.18% +2.18%
==========================================
Files 145 171 +26
Lines 13978 19434 +5456
==========================================
+ Hits 10484 15001 +4517
- Misses 3494 4433 +939 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Wauplin
left a comment
There was a problem hiding this comment.
Nice catch 🤦 How did you ended up finding about this ?
|
Thanks for your fast review, @Wauplin. We were using the same regex in |
|
Thanks for backporting it :) |
|
This PR has been shipped as part of the v1.16.0 release. |
Fix catch-all empty string in CI pytest --only-rerun.
This PR fixes a typo in the
--only-rerunregular expression pattern in thePYTESTcommand (python-tests.ymlworkflow file) by removing an extra pipe character.||(double pipe) in the--only-rerunregex pattern in thePYTESTcommand, which introduced an empty alternation that matched every test failure, causing all failing tests to be retried rather than only the intended transient errors.Note
Low Risk
Low risk: CI-only change that narrows the
--only-rerunregex so retries only trigger for intended transient errors instead of matching everything.Overview
Fixes a typo in
.github/workflows/python-tests.ymlby removing an empty alternation from thepytest --only-rerunregex.This prevents the CI rerun plugin from retrying all failures and limits reruns to the specified transient error patterns (e.g., timeouts/502/504).
Reviewed by Cursor Bugbot for commit b163ea4. Bugbot is set up for automated code reviews on this repo. Configure here.