[CLI] No traceback on LocalEntryNotFoundError#4190
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
…-traceback-on-local-entry-not-found
Contributor
|
This PR has been shipped as part of the v1.15.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR:
cc @julien-c
Note
Low Risk
Low risk: changes are limited to CLI exception-to-message formatting and should not affect core download behavior. Main risk is minor messaging/regression in which exception gets matched/printed for offline/local-cache error cases.
Overview
Improves CLI error formatting for offline/local-cache download scenarios by handling
LocalEntryNotFoundErrorexplicitly and printing a concise message (preferring the underlying__cause__) instead of a traceback.Adds
OfflineModeIsEnabledto the known-exception mapping so offline-mode errors also render cleanly viaformat_known_exception.Reviewed by Cursor Bugbot for commit bb70288. Bugbot is set up for automated code reviews on this repo. Configure here.