[CLI] Remove progress bars on skills update#4179
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
This PR has been shipped as part of the v1.14.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing a
hf skills updateorhf skills add, some files are downloaded from HF Bucket https://huggingface.co/buckets/huggingface/skills (see #4175) which produces unrelated logs/progress bars in the CLI "downloading files from bucket". Let's remove this as it's misleading to the user in a "skills update" context.To simplify some logic, I've also made
disable_progress_barsusable as a context manager. I've also updated the tests to use pytest syntax (much simpler to read) and made sure everything was still working exactly the same.I'll merge this PR once CI is clean to avoid having conflicts with my follow-up PR.
Note
Medium Risk
Touches shared progress-bar state management and changes
disable_progress_barsinto a context-manager class, which could subtly affect global enable/disable behavior across CLI commands if misused.Overview
Suppresses misleading download progress output during
hf skills add/hf skills updateby wrapping marketplace/bucket fetches inwith disable_progress_bars().Refactors progress-bar control so
disable_progress_barscan be used as a context manager that restores the previous state on exit, and simplifies CLI call sites (buckets cpstdout download,spaces hot-reloadfile fetch) to use the new pattern.Rewrites
test_utils_tqdm.pyto purepyteststyle and adds coverage for the new context-manager semantics (restoration, nesting, no-op when already disabled).Reviewed by Cursor Bugbot for commit a8c1a99. Bugbot is set up for automated code reviews on this repo. Configure here.