Add Daft to list of integrated libraries for datasets#1892
Conversation
davanstrien
left a comment
There was a problem hiding this comment.
Very cool! I think it could be worth making the distinction between pushing to the Hub vs writing to a dataset.Dataset a little bit more explicit but this is looking very nice otherwise 🤗
|
awesome ! it would also be cool to showcase how to load/push multimodal data |
@lhoestq thanks for the feedback! I'm not yet happy about Daft's story around the Hugging Face Dataset multimodal types (images, video, audio) and they are currently just represented as some nested binary type in Daft. I plan on building better integrations for them soon, and once we have that I'd love to update these docs with more info if that works. |
|
sounds good, looking forward for the multimodal integration :) feel free to ping me if you have questions on the structure or if I can help |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@davanstrien this (and the documentation images PR) is ready to merge on my end. I don't have the permissions for it, so feel free to do so! |
pcuenca
left a comment
There was a problem hiding this comment.
Could you please rebase or fix the conflicts so the PR only shows the pertinent changes @kevinzwang? 🙏
85a79de to
ba4745c
Compare
ba4745c to
ca81dea
Compare
@pcuenca done! |
pcuenca
left a comment
There was a problem hiding this comment.
Good for me whenever @davanstrien is happy with it.
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Daft now has native integration for reading and writing Hugging Face datasets, which we have documented in our docs pages! This PR adds the corresponding docs to the Hugging Face docs.
This PR relies on the
daft_hf.pngfile being uploaded to thehuggingface/documentation-imagesrepo, which I have made a PR for here. The image: