Conversation
McPatate
approved these changes
Dec 30, 2024
This was referenced Dec 30, 2024
Comment on lines
+216
to
+218
| let mut path = dirs::home_dir().expect("Cache directory cannot be found"); | ||
| path.push(".cache"); | ||
| path.push("huggingface"); |
There was a problem hiding this comment.
Hello! I'd like to ask why an implementation for creating a Cache instance without using environment variables is provided here, and why it is set as the default behavior? Generally speaking, shouldn't it be the default to read environment variables?🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.