Resumable downloads.#84
Merged
Merged
Conversation
McPatate
reviewed
Dec 30, 2024
McPatate
left a comment
Member
There was a problem hiding this comment.
1st part of my review, trying to figure out how things work in tokio
| let new_size = (size as f32 * truncate) as u64; | ||
| file.set_len(new_size).unwrap(); | ||
| let mut blob_part = blob.clone(); | ||
| blob_part.set_extension(".part"); |
Contributor
Author
There was a problem hiding this comment.
It's done on purpose to have it hardcoded in the test. I don't want my test to change when library code changes.
| let mut file = std::fs::File::create(&filepath)?; | ||
|
|
||
| let mut res = self.download_from(url, 0u64, size, &mut file, filename, &mut progress); | ||
| let mut file = match std::fs::OpenOptions::new().append(true).open(&filepath) { |
Member
There was a problem hiding this comment.
Suggested change
| let mut file = match std::fs::OpenOptions::new().append(true).open(&filepath) { | |
| let mut part_file = match std::fs::OpenOptions::new().append(true).open(&filepath) { |
| .await | ||
| { | ||
| Ok(mut f) => { | ||
| let len = f.metadata().await.unwrap().len(); |
| 0 | ||
| } | ||
| } | ||
| Err(_err) => { |
Member
There was a problem hiding this comment.
Suggested change
| Err(_err) => { | |
| Err(_) => { |
This was referenced Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes on the strategy here.
Sync:
Tokio:
Since we're multiplexing, writes are not happening in order. We could:
u64at the very end of the partial file. When resuming, we read that single int, and resume from there. Anything fishy and we drop the resumability.This feels simpler that the more complex version, seems to work quite well in practice (only tested on stable networks right now).
The probability for storing invalid files seems low (since commit happens at a single location both in code and in file).