feat(api): add lfs metadata#8
Merged
Merged
Conversation
Contributor
|
Can we add a test for it ? (Also so I can have a look at what models return that could be interesting in other places to get file sizes without Range:0-0. |
Narsil
reviewed
Aug 1, 2023
Narsil
left a comment
Contributor
There was a problem hiding this comment.
Quite nice.
I propose a different (simpler imho) internals.
Otherwise looks good. Not sure how cargo fmt didn't pick up those before.
|
|
||
| /// serde_json error | ||
| #[error("Serde json error: {0}")] | ||
| SerdeJson(#[from] serde_json::Error), |
Contributor
There was a problem hiding this comment.
How were we getting away without it before, is it the map(Box?) ?
Member
Author
There was a problem hiding this comment.
Response::into_json returns an io::Result<T> while serde_json::from_value returns a Result<T, serde_json::Error>
Member
Author
There was a problem hiding this comment.
And reqwest::Response::json returns a Result<T, reqwest::Error>
in favor of returning raw request builder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full lfs object looks like this :
Needed for the repo scanner