Skip to content

Move ModelInfo up and rename as RepoInfo.#4

Merged
Narsil merged 2 commits into
mainfrom
move_up_model_info
Jul 27, 2023
Merged

Move ModelInfo up and rename as RepoInfo.#4
Narsil merged 2 commits into
mainfrom
move_up_model_info

Conversation

@Narsil

@Narsil Narsil commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

Just using good idea from #2 while ignoring is_main which I find a bit niche for now).

Narsil added 2 commits July 27, 2023 17:21
Co-Author: Luc Georges<luc@huggingface.co>
@Narsil Narsil force-pushed the move_up_model_info branch from db0e4ea to fdf7316 Compare July 27, 2023 15:38
@Narsil Narsil merged commit d981bfe into main Jul 27, 2023
Comment thread src/api/tokio.rs
model_info,
ModelInfo {
RepoInfo {
sha: "2dd3f79917d431e9af1c81bfa96a575741774077".to_string(),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will eventually break when refs/convert/parquet is updated

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's OK !

@McPatate McPatate deleted the move_up_model_info branch August 1, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants