Add proxy from env.#34
Merged
Merged
Conversation
|
hi @Narsil, |
I also encountered this issue. Would like to bump the priority of releasing a new version with this patch. |
|
Kindly ping @Narsil have no idea about hf release schedule, but seems we haven't cut a new one for a long time, maybe worths a new release? We also meet this problem and solved it by enable the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In mainland China, people usually need to access the international internet through a proxy.
Otherwise, they may encounter connection errors.
For example: error trying to connect: tcp connect error: Connection timed out (os error 110)
So it's necessary to support obtaining proxy configurations from environment variables to facilitate the use by users in mainland China.