Adding ApiBuilder::from_cache method.#27
Merged
Conversation
Member
|
I use the home crate in llm-ls, as they do in cargo: let home_dir = home::home_dir().ok_or(()).expect("failed to find home dir");Or am I misunderstanding the issue? |
Contributor
Author
|
This isn't linked to that. It's just that APPS on mobile (iOS, android) are run as users which do NOT have home directories altogether. |
McPatate
approved these changes
Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out
dirs::home_dir()can fail on Android apps (there is no $home_dirset for them).
This is probably super niche, and I didn't find any good way to detect the location cache folder,
therefore I simply include these new functions to allow creating and API from a functional cache.
This is interesting anyway for anyone wanting to use a custom cache location.