You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm hesitant to even change the internals of ApiRepo to make them own a CacheRepo.
That would remove a bunch of clone, but potential discrepancy between self.api.cache.repo(repo) vs self.cache_repo
download_tempfile is private, therefore consistency doesn't matter. IIRC there's a good reason they don't need the same things.
Why does Api have a cache repo?
To get the token, and to be able to create a CacheRepo :)
I think the way to go to clean this would be to have Api be split between the Cache owned (the exposed user level API) and the actualy InternalApi which would contain only the necessary things to make actual http calls. Then
ApiRepo could own InternalApi and CacheRepo and we avoid the issue of ApiRepo owning both CacheRepo and Api.Cache (being potentially out of sync)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to what is being done for
ApivsApiRepo.I'm hesitant to even change the internals of
ApiRepoto make them own aCacheRepo.That would remove a bunch of clone, but potential discrepancy between
self.api.cache.repo(repo)vsself.cache_repo