Fix failing API tests due to outdated model metadata expectations#124
Merged
Conversation
Narsil
approved these changes
Sep 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix failing API tests due to outdated model metadata expectations
Problem
Two tests in the test suite were failing (2/26 tests):
detailed_infotest insrc/api/sync.rsinfo_requesttest insrc/api/tokio.rsBoth tests were failing because they contained hardcoded assertions against live API responses from the
mcpotato/42-eicar-streetmodel on Hugging Face Hub. The model's metadata had naturally evolved over time, causing the tests to expect outdated values.Root Cause
The tests were performing exact JSON comparisons against live API responses, which is inherently brittle since:
Changes Made
Updated the hardcoded test expectations in both sync and async API implementations to match the current state of the model metadata:
sync.rs changes:
"likes": 3→"likes": 4in thedetailed_infotest"szk2024/est"to thespacesarraytokio.rs changes:
"likes": 3→"likes": 4in theinfo_requesttest"szk2024/est"to thespacesarrayImpact
Future Considerations
These tests validate the exact API response format but are vulnerable to live data changes. Consider:
Testing
Technical Details
Files Changed
src/api/sync.rs- Updated model metadata expectations in sync API testsrc/api/tokio.rs- Updated model metadata expectations in async API testCommit History
Branch Information
test-fixesmainValidation
Before Fix
After Fix