fix: handle response status code-based errors in ApiRepo.info before deserialization#109
Merged
Merged
Conversation
…e deserialization Currently, deserialization is immediately attempted after receiving a response from the remote server without checking its validity. This results in inscrutable errors like `request error: error decoding response body` when the returned response has a non-2XX status code and the `ApiError` value is propagated upward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, deserialization is immediately attempted after receiving a response from the remote server without checking its validity. This results in inscrutable errors like
request error: error decoding response bodywhen the returned response has a non-2XX status code and theApiErrorvalue is propagated upward. This PR addresses this by calling theerror_for_status()method beforejson().On a related note, it might be worth updating
ApiBuilderto either raise an error when an empty authentication token is passed to it or, alternatively, to skip the authorization key in the header when the token's empty.