Skip to content

Add a check for the ToC#54

Merged
sgugger merged 4 commits intomainfrom
toc_check
Dec 15, 2021
Merged

Add a check for the ToC#54
sgugger merged 4 commits intomainfrom
toc_check

Conversation

@sgugger
Copy link
Contributor

@sgugger sgugger commented Dec 13, 2021

This PR adds a check for the ToC, specifically that it contains all the doc-generated files. If it does not, the doc-builder will now error (like sphinx used to).

As a result this PR shouldn't be merged without its counterpart on the Transformers side (which adds missing files in the ToC).

@sgugger sgugger requested a review from LysandreJik December 13, 2021 21:52
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clear! LGTM!

@sgugger sgugger merged commit 0b62745 into main Dec 15, 2021
@sgugger sgugger deleted the toc_check branch December 15, 2021 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants