Ignore all errors when trying to unpack refs from an external library#383
Merged
Conversation
LysandreJik
approved these changes
Jun 8, 2023
LysandreJik
left a comment
Member
There was a problem hiding this comment.
LGTM aside from the print!
Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @mishig25 but I know you're off.
Currently the documentation on Transformers latest release is not building because the
objects.invon the stable doc of tokenizers is invalid (might be worth rebuilding the doc on tokenizers latest release @ArthurZucker ).This PR makes us ignore that error (which appears in
zlib.decompress(b"".join(object_lines)).decode().split("\n")). It could be refined to the actual exception returned by zlib but I don't have time to debug this right now, so going for the quick fix :-)