Skip to content

Handle windows paths with back slashes#307

Closed
mishig25 wants to merge 4 commits into
mainfrom
windows_path
Closed

Handle windows paths with back slashes#307
mishig25 wants to merge 4 commits into
mainfrom
windows_path

Conversation

@mishig25

@mishig25 mishig25 commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

Closes #306
Closes #298

Could you test it locally on your machine? Thanks a lot

You can test this branch locally by:

# 1. install from source in dev mode (if not already)
git clone https://github.com/huggingface/doc-builder
cd doc-builder
pip install -e .
# 2. switch to this branch
git checkout windows_path
# 3. preview locally
doc-builder preview ...

cc: @dylanebert github is not letting me add you as a reviewer (probably, some credentials issue)

@mishig25 mishig25 changed the title Handle windows paths with bask slashes Handle windows paths with back slashes Oct 3, 2022
@mishig25 mishig25 requested a review from natolambert October 3, 2022 20:24
mishig25 and others added 3 commits October 3, 2022 21:58
This reverts commit 8a741d5.
)

Co-authored-by: dylanebert <dylan.ebert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Windows] hardcoded '/' in preview Windows compatibility issues

1 participant