Gh workflows support --not_python_module flag#153
Merged
Merged
Conversation
sgugger
reviewed
Mar 25, 2022
sgugger
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this! I think we can make the new arg more general.
Comment on lines
+16
to
+17
| # supply --not_python_module for HF Course | ||
| module_flag: |
Contributor
There was a problem hiding this comment.
I'd call this additional_args so we can use it to pass anything.
Comment on lines
+17
to
+20
| # supply --not_python_module for HF Course | ||
| module_flag: | ||
| type: string | ||
| default: '' |
Contributor
There was a problem hiding this comment.
Same comments on this file.
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
LysandreJik
approved these changes
Mar 25, 2022
LysandreJik
left a comment
Member
There was a problem hiding this comment.
This is a great addition, thanks @mishig25!
Contributor
Author
|
Thanks a lot fir the reviews 😊 merging it since trying to get the doc-build asap |
1 similar comment
Contributor
Author
|
Thanks a lot fir the reviews 😊 merging it since trying to get the doc-build asap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so that we can use GH templates in course new frontend Ci here