Skip to content

Switch default branch to main and fix tests#151

Merged
sgugger merged 2 commits into
mainfrom
notebook_main
Mar 25, 2022
Merged

Switch default branch to main and fix tests#151
sgugger merged 2 commits into
mainfrom
notebook_main

Conversation

@sgugger

@sgugger sgugger commented Mar 24, 2022

Copy link
Copy Markdown
Contributor

This PR changes the default branch to "main" everywhere master is used, in particular for the notebook building job (for the rest it's the default in internal functions, which is trumped by the version set when building the doc anyway).

It also fixes a few tests due to the recent reorganization in Transformers splitting file_utils in several submodules.

@sgugger sgugger requested review from LysandreJik and mishig25 March 24, 2022 18:21

@mishig25 mishig25 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this! does it mean that for datasets need to specifically supply version master in its GH workflows since they have not migrated to main yet?

@sgugger

sgugger commented Mar 25, 2022

Copy link
Copy Markdown
Contributor Author

No, the command picks the default branch in the _config.py and sets it to master.

@LysandreJik LysandreJik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sgugger sgugger merged commit 76c1228 into main Mar 25, 2022
@sgugger sgugger deleted the notebook_main branch March 25, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants