Skip to content

Optimum fixes#149

Merged
sgugger merged 3 commits into
mainfrom
optimum_fixes
Mar 21, 2022
Merged

Optimum fixes#149
sgugger merged 3 commits into
mainfrom
optimum_fixes

Conversation

@sgugger

@sgugger sgugger commented Mar 17, 2022

Copy link
Copy Markdown
Contributor

In a namespace module (like optimum), submodules won't directly appear as attributes. You need to import them at least one explicitly before they do. This PR does that.

@sgugger sgugger requested a review from LysandreJik March 17, 2022 16:19

@LysandreJik LysandreJik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for investigating @sgugger @lewtun!

@sgugger sgugger merged commit 6f68918 into main Mar 21, 2022
@sgugger sgugger deleted the optimum_fixes branch March 21, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants