Course changes#148
Merged
Merged
Conversation
sgugger
approved these changes
Mar 17, 2022
sgugger
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for working on this!
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
f55b3a4 to
d79d0d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes needed for the hf course
Feel free to ignore the svelte side.
For the python side, the big change is adding a flag
not_python_moduletobuildcommand & based onnot_python_modulewe make sure to not doimportlib.import_module(course)Unlike transformers or datasets, course is just a set of mdx files, not a python module