Skip to content

Wrong Z_Image guidance scale implementation #12905

@Trgtuan10

Description

@Trgtuan10

Describe the bug

With cfg implementation of Z_image: pred = pos + current_guidance_scale * (pos - neg), the do_classifier_free_guidance function should be implement: return self._guidance_scale > 0, but currently in diffusers code: return self._guidance_scale > 1

For example, if I set guidance = 0.5, it works as guidance = 0 and it is incorrect.

Reproduction

No

Logs

System Info

0.36.0

Who can help?

@yiyixuxu @sayakpaul @DN6

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingroadmapAdd to current release roadmap

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions