Skip to content

fix: 🐛 extend takes one argument (a list), not one arg per elem#1116

Merged
severo merged 4 commits into
mainfrom
fix-list-extend-bug
May 2, 2023
Merged

fix: 🐛 extend takes one argument (a list), not one arg per elem#1116
severo merged 4 commits into
mainfrom
fix-list-extend-bug

Conversation

@severo

@severo severo commented May 2, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@severo severo requested a review from a team May 2, 2023 09:46
@HuggingFaceDocBuilder

HuggingFaceDocBuilder commented May 2, 2023

Copy link
Copy Markdown
Collaborator

The documentation is not available anymore as the PR was closed or merged.

@severo

severo commented May 2, 2023

Copy link
Copy Markdown
Collaborator Author

After merging, we should relaunch the jobs with UnexpectedError error code -> #1117

Note the increase in this Error code after the big backfill we did last week:

Capture d’écran 2023-05-02 à 11 48 34

Not sure if all of them are due to this bug (we would have to look at the details field)

@lhoestq lhoestq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch !

@severo severo merged commit 6e9d1be into main May 2, 2023
@severo severo deleted the fix-list-extend-bug branch May 2, 2023 13:36
@severo

severo commented May 2, 2023

Copy link
Copy Markdown
Collaborator Author

That's what unit tests are helpful for... and I hadn't written one.

@albertvillanova albertvillanova linked an issue May 9, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The error is not reported as expected

3 participants