Add RPC debug_traceCallMany#4
Merged
Merged
Conversation
yiteng-guo
reviewed
Jun 28, 2022
| ) | ||
|
|
||
| type BlockContext struct { | ||
| type BlockOverrides struct { |
There was a problem hiding this comment.
eth_callMany.go and eth_callMany_test.go changes look good to me. Could you push these two changes to eth_callMany branch? Let's make sure the PR we submit to erigon includes this change.
Also remember to change the spec you have on your issue accordingly since we change the RPC API here.
There was a problem hiding this comment.
See my comments below. I'll merge this to eth_callMany once you address all comments.
yiteng-guo
reviewed
Jun 28, 2022
yiteng-guo
left a comment
There was a problem hiding this comment.
tracing change also looks good to me. I feel like we can refactor this a lot so there wouldn't be much duplicated code but it looks like other tracing functions also duplicate code a bit? I'm neutral on this and will defer the decision to erigon team.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.