Fixed ClassNotFoundException when creating okhttp3.OkHttpConnector with Cache#627
Merged
Conversation
With okhttp 3, the package name changed. In the okhttp3.OkHttpConnector, the incorrect class is loaded, creating a ClassNotFoundException at runtime when okhttp3 only is loaded.
bitwiseman
approved these changes
Nov 27, 2019
Member
|
No way to detect this aside from better code reviews or having a test project that only has okhttp3 and not okhttp. 😞 Thanks! |
Contributor
Author
|
I figured it was a "copy-paste" issue, no big deal. Imports are not the first thing I think of and here I got angry because the class was available in the classpath. But not the correct class.. |
Member
|
Published as v1.101. |
ClassNotFoundException when creating okhttp3.OkHttpConnector with Cache
ClassNotFoundException when creating okhttp3.OkHttpConnector with Cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
okhttp3.OkHttpConnectorclass is still referencing theokhttp.CacheControl. However, this class is not part of OkHttp 3.x or 4.x. This creates aClassNotFoundExceptionat runtime on projects creating aokhttp3.OkHttpConnectorwith aCache.Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn install sitelocally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.