Removed permission field in createTeam. It is deprecated in the API#619
Conversation
69088ce to
bae2f19
Compare
|
I rebased your changes on master to make the PR cleaner. Thanks for this PR it is a good catch. However, removing Instead you can mark the existing methods that have public GHTeam createTeam(String name, Collection<GHRepository> repositories) throws IOException {
// ...
}
/**
* ...
* @deprecated use {@link #createTeam(String, Collection) instead.
*/
@Deprecated
public GHTeam createTeam(String name, Permission p, Collection<GHRepository> repositories) throws IOException {
// ...
} |
bitwiseman
left a comment
There was a problem hiding this comment.
Use @deprecated instead of introducing API changes.
a81407b to
30662a0
Compare
|
Agreed! It was a long shot to remove those fields. I just did a hard push on the remote branch & the CI Build job failed. How do I re-trigger it? |
30662a0 to
d4d2792
Compare
|
@bitwiseman When is the next release planned? |
|
Done v1.101 is out. |
Description
https://developer.github.com/v3/teams/#create-team had deprecated the
permissionfield but the library still expects this field. https://github.com/github-api/github-api/blob/da11702f6815f658014f33ce724f0cd2e4501081/src/main/java/org/kohsuke/github/GHOrganization.java#L387This PR refactors the code to remove the permission field.
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn install sitelocally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.