Skip to content

Branch missing#615

Merged
bitwiseman merged 7 commits into
hub4j:masterfrom
alexanderrtaylor:BranchMissing
Nov 19, 2019
Merged

Branch missing#615
bitwiseman merged 7 commits into
hub4j:masterfrom
alexanderrtaylor:BranchMissing

Conversation

@alexanderrtaylor

@alexanderrtaylor alexanderrtaylor commented Nov 15, 2019

Copy link
Copy Markdown
Contributor

Description

Fixing Issue #607 where if you get a good return code for a single branch but it does not contain any details it will have null values for everything which should throw an error

  • Push your changes to a branch other than master. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn install site locally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.

I dont love the way I did the error catching so I am open to suggestions. Also JavaDocs are new for me so any help would be appreciated

Alex Taylor and others added 7 commits November 13, 2019 15:07
Added a test so that we can prove when this issue is fixed
Added GHBranch creator and added a test to make sure it works
Adjusted format according to standard from repo
Changed Exception type and added a comment
@bitwiseman bitwiseman merged commit d2ce7c1 into hub4j:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants