Skip to content

Implement Meta endpoint#611

Merged
bitwiseman merged 7 commits into
hub4j:masterfrom
PauloMigAlmeida:master
Nov 14, 2019
Merged

Implement Meta endpoint#611
bitwiseman merged 7 commits into
hub4j:masterfrom
PauloMigAlmeida:master

Conversation

@PauloMigAlmeida

@PauloMigAlmeida PauloMigAlmeida commented Nov 14, 2019

Copy link
Copy Markdown
Contributor

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • [] Push your changes to a branch other than master.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn install locally. This may reformat your code, commit those changes.

I was working on #582 when I realised that the /meta endpoint wasn't available in this library.
I created the Javadocs, tests and removed some unused imports on GitHubTest

@bitwiseman

Copy link
Copy Markdown
Member

@PauloMigAlmeida
I cleaned up GHMeta (7d1e977) and then added some examples of different ways to create data objects (7e05ce3) to explain some of the options and reasoning.

@bitwiseman bitwiseman merged commit 1f619f3 into hub4j:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants